-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the audio.com upload flow #4743
Conversation
Tested. A new issue was found: #4747 |
@@ -579,7 +586,7 @@ UploadOperationHandle UploadService::Upload( | |||
mServiceConfig, fileName, projectName, isPublic, | |||
std::move(completedCallback), std::move(progressCallback)); | |||
|
|||
mOAuthService.ValidateAuth([operation](std::string_view authToken) | |||
mOAuthService.ValidateAuth([operation, this](std::string_view authToken) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
isn't used
Tested and confirmed the following to the Audio.com upload flow: track title field is added and required for upload, track title field is focused upon opening the dialog, Anonymous uploads are not allowed, linking audio.com account works as expected (auto and manual), and audio.com link is opened immediately upon upload. Tested the above in Windows, MacOS, and Linux. |
Recommended: